Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to expose additional path over http://meteor.local/<prefix> on Cordova #5203

Closed
wants to merge 2 commits into from
Closed

Ability to expose additional path over http://meteor.local/<prefix> on Cordova #5203

wants to merge 2 commits into from

Conversation

wojtkowiak
Copy link
Contributor

This is a solution for problems mentioned here #3799
@martijnwalraven: I know you are planning on rewriting the whole thing but take a look and let me know if this could maybe be accepted at least as a solution for now. If you have a different approach to this problem also let me know. This is just something I made for my team and we are already using this in some apps for like a half a year now. If this does not fit your plans that is ok, maybe at least you will be able to use some of this code 馃槃
The crucial part is here: meteor/com.meteor.cordova-update#6

Code lacks tests but I am having a problem with meteor test-packages --ios-device - whenever I change anything in the test meteor goes into endless loop saying that the client was modified x1560
times and goes up every second. No idea currently, maybe I should report it as bug.

Api is described in methods comments.

Demo:

  1. checkout https://github.com/wojtkowiak/test
  2. checkout https://github.com/wojtkowiak/com.meteor.cordova-update/tree/additional-data-path
  3. checkout https://github.com/wojtkowiak/meteor/tree/additional-path
  4. on line https://github.com/wojtkowiak/meteor/blob/additional-path/packages/webapp/package.js#L22 change the tarball url to file:///path/to/checkouted/com.meteor.cordova-update
  5. run the app from checkout

@wojtkowiak wojtkowiak mentioned this pull request Sep 18, 2015
Closed
@martijnwalraven
Copy link
Contributor

Thanks! I'm indeed in the process of rewriting the plugins, so I don't think this is a good time to merge a pull request. I will take a good look at your approach though, because I agree exposing additional paths is probably the way to go. I'm planning on releasing a preview of the new plugins soon, hopefully sometime next month.

The meteor test-packages --ios-device bug does seem like something worth reporting, especially if you have a good reproduction. Does this also happen on 1.2 RC?

@wojtkowiak
Copy link
Contributor Author

Well if we would decide already how the API should look like and ensure that it will not change I guess this could be merged earlier. But that just my opinion.
Anyway let me know if I can help in any way. If you already have your work somewhere I can even port my changes to your new solution. I'd really like to see my team using standard release of meteor instead of my fork 馃槃

About the error I will prepare a repro and submit it.

@wojtkowiak
Copy link
Contributor Author

Just a reminder, if I can help in any way let me know.

@geekgonecrazy geekgonecrazy mentioned this pull request Nov 23, 2015
Closed
@webwurst
Copy link

Any news on this? :)

@martijnwalraven
Copy link
Contributor

It's not in the first Meteor 1.3 Cordova beta yet, but it is on the list of features to work on.

@stubailo
Copy link
Contributor

This is going to be a first-class feature in the new Meteor cordova thing.

@stubailo stubailo closed this Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wojtkowiak @martijnwalraven @webwurst @stubailo